Replace fastutil with HPPC #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@suraj-subrahmanyan The advantage of using |
Contributor
Author
|
Yea, that makes sense -- I was actually thinking the same since it would likely have similar performance and contribute nothing to the fatjar size. However, org.apache.lucene.internal.hppc.LongHashSet was added in Release 9.11.0 of Lucene and by upgrading the Lucene version Anserini breaks (?) |
Member
Oh, I see... :( LG for now. Okay, let me coordinate with #2939 for merging. |
lintool
approved these changes
Sep 16, 2025
This was referenced Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addresses issue #2937 . I ran a JMH microbenchmark on deletes.contains() line as it runs for each tweet processed.
Speed Comparison:
Not included here, but in a JVM benchmark, Java HashSet had a much high memory consumption and is inconsistent.
Size comparison:
Since com.carrotsearch.hppc dependency is small and has the relative performance of fastutil, it is a good replacement. Also, com.carrotsearch.hppc is more stable than Lucene's org.apache.lucene.internal.hppc.LongHashSet since it is public library.