Refactor test cases to extract common helper function #3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3048 +/- ##
=========================================
Coverage 72.58% 72.58%
Complexity 1342 1342
=========================================
Files 187 187
Lines 12648 12648
Branches 1450 1450
=========================================
Hits 9180 9180
Misses 2915 2915
Partials 553 553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sahel-sh
reviewed
Nov 21, 2025
src/test/java/io/anserini/StdOutStdErrRedirectableLuceneTestCase.java
Outdated
Show resolved
Hide resolved
sahel-sh
reviewed
Nov 21, 2025
src/test/java/io/anserini/index/IndexCollectionInovcationsTest.java
Outdated
Show resolved
Hide resolved
sahel-sh
approved these changes
Nov 21, 2025
Member
Author
|
Addressed comments, thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3042 (comment)
Previous implementation had
StdOutStdErrRedirectableLuceneTestCaseandStdOutStdErrRedirectableTestCase, one of which extendsLuceneTestCase. All but two cases can extend the Lucene version, but for the two exceptions (due to weird concurrency bugs), I had to duplicate the code that save/restores stdout/stdrr. It was either that or have two separate classes.