Fixed underscores and made merge indice calculation more robust #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed behavior with token merge indice calculation when it comes to punctuation and numbers
Fixed searching for underscores and made the searching more robust. Had to update this code to work with the commit that went through while I was making it.
daemon
approved these changes
Dec 8, 2022
Member
daemon
left a comment
There was a problem hiding this comment.
Nicely done. I was planning to address it at some point, but you beat me to the punch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the merge indice calculation could fail rather easily, and didn't work with underscores. Now you can have things such as underscores in the middle of words (or at all), quotation marks, every symbol but a space in your search. The previous code would fail with a prompt such as
hololive, amane_kanata, 1girl, angel_wings, hairclip, blue eyesand searching forangel_wings, as it would becomeangel</w>_</w>wings</w>, and the code couldn't handle punctuation anywhere but the end.