Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

Excellent work!

I have some suggestions. As you place the iterator on the CFDictionary I think it is good practice to place it in the CFDictionary.js file. With that it should only use pure JavaScript. This will make it work on pure CFDictionary dictionaries too.
Also as you use a very lazy and efficient generator function with the yield keyword it would be good practice to continue with that and use a lazy way to iterate over the keys. Now the first thing this function does is to create a new array with all the keys. It is costly if it is a dictionary with many values.

I propose something like the following:

CFDictionary.prototype[Symbol.iterator] = function*()
{
    // 'this' inside this function will be the CFDictionary instance.
    const keys = this._keys;
    const buckets = this._buckets;

    for (const key of keys)
    {
        // The 'yield' keyword is part of the generator function. It pauses
        // execution and provides the [key, value] array to the for...of loop.
        yield [key, buckets[key]];
    }
};

This will use for of ... on the array of keys that is also lazy and efficient and the behavior when deleting values when iterating will be the default JavaScript behavior. Extracting the size at the beginning to use when iterating can cause other behaviors when deleting or inserting value into the dictionary when iterating over it.

Lastly we should have some test cases in CFDictionaryTest.j

Milestone: Someday. Labels: #needs-review, Objective-J. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

Milestone: Someday. Labels: #ready-to-commit, Objective-J. What's next? The changes for this issue are ready to be committed by a member of the core team.

This is good now but I think we should have the iterator in CFDictionary. That means we need to add it in the Objective-J library in the runtime too. I will check how we can do this. I would like to just have one source for the Objective-J library but that might have to wait.

Milestone: Someday. Labels: #needs-improvement, Objective-J. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

@mrcarlberg CFDictionary lives in another repo, so IMHO we can merge this now and fix it in the other repo independently.

I found a compiler warning and I have also released a new version of the runtime that include the generator in the CFDictionary.js file. You can now move the generator to the CFDictionary.js file here too. Please try to position the function at the same place as in the runtime.

should i copy the function into Objective-J/CFDictionary.js (in this repo)?
is this for cosmetical reasons?
from my understanding, the whole Objective-J folder in cappuccino is not used at all, isn't it?
imho we should consolidate the runtime and the main repo, unless i misunderstood something deeply.

My understanding is that the Objective-J is made for the Browser in the Cappuccino project. If you don't add the function you will not be able to use it when running in the Browser. The Objective-J in the obj-runtime is only for NodeJS. This is not perfect as we have it in two places but as it is right now.

My understanding is that the Objective-J is made for the Browser in the Cappuccino project. If you don't add the function you will not be able to use it when running in the Browser. The Objective-J in the obj-runtime is only for NodeJS. This is not perfect as we have it in two places but as it is right now.

have a look at #3126
the manual tests in this branch run fine on my system.
from this observation i would argue that the stuff inside Objective-J is not used at all (latest change there 3 years ago)

Yes, but where is the Browser version of the Objective-J framework built? It is not built in the obj-runtime as it will only build the NodeJS version. I believe that If you don't add the generator function here you will not be able to use it in the Browser. It is added in the obj-runtime so the automatic test will work now.

Yes, but where is the Browser version of the Objective-J framework built? It is not built in the obj-runtime as it will only build the NodeJS version. I believe that If you don't add the generator function here you will not be able to use it in the Browser. It is added in the obj-runtime so the automatic test will work now.

excellent point! i will test this and let you know.

in this branch, CPDictionary works in the browser

Yes, because you have added the generator function in the CPDictionary.j file. If you remove the generator function it will not work in the Browser but it will for the unit tests.

does not work in the browser anymore after moving from CP to CF.
i am 100% sure i rebuilt this branch before testing.

i am not surprised by this observation as cappuccino still 100% works in the browser without all the stuff in the Objective-J directory (see #3126). The source of the runtime for the browser must be located somewhere else (IMHO).

could it be that the 'real' stuff is in node_modules/@objj/runtime/Objective-J/Browser ?
last modified in June 28 in 2025

if so, where is this coming from?

For me this is working! I get the three alerts when I run your for of loop above in my project. I believe you are using some old version of the Objective-J framework in your app? Not the one built by the Cappuccino project.

Regarding #3126, I don't believe that your assumptions are correct. The only place the Browser version of the Objective-J framework is built is in the Cappuccino project.

node_modules/@objj/runtime/Objective-J/Browser is not used in the Node version. It is just there because most of the Objective-J folder in Node is a copy of the Objective-J folder from the Cappuccino project. It is probably last modified in June 28 in 2025 as you installed or updated the npm module that date.

jake install gives me fresh files in cappuccino/dist/cappuccino/Frameworks and cappuccino/dist/objective-j/Frameworks/Objective-J

however, when running jake install in the branch from this PR, cappuccino/dist/objective-j/Frameworks/Objective-J/Objective-J.js does not contain "function*" (as it shoud from the changes in Objective-J/CFDictionary.js in this PR)
do you have any idea why this is?

I searched for "Symbol.iterator" and I found it on CFDictionary. What did you do?

> git checkout new-for-of-iterator-for-CPDictionary
> npm install
> npm update
> jake install
> grep Symbol.iterator dist/objective-j/Frameworks/Debug/Objective-J/Objective-J.js
    CFDictionary.prototype[Symbol.iterator] =     function *()
            pp[Symbol.iterator] =             function()
> 

indeed, it is in dist/objective-j/Frameworks/Debug/Objective-J/Objective-J.js
however, it is not in dist/objective-j/Frameworks/Objective-J/Objective-J.js

It is in my dist/objective-j/Frameworks/Objective-J/Objective-J.js

...CFDictionary.prototype[Symbol.iterator]=function*(){const e=this._keys,t=this._buckets;for(const r of e)yield[r,t[r]]}...

mine is ...Symbol&&(et[Symbol.iterator]=function(){var e=this;return{next:function(){var t=e.getToken();return{done:t.type===w.eof,value:t}}}}),et.nextToken...

I have that function too in my file but I also have the generator function for CFDictionary. Has the file dist/objective-j/Frameworks/Objective-J/Objective-J.js and dist/objective-j/Frameworks/Debug/Objective-J/Objective-J.js been updated at the same time for you? Maybe something strange happens when you build the frameworks?

You can also check the file in the build folder: Should be here: <your build folder>/Release/Objective-J/Objective-J.js

daboe01@MacBook-Pro-9 cappuccino % ls -la dist/objective-j/Frameworks/Objective-J/Objective-J.js
-rw-r--r-- 1 daboe01 staff 354744 23 Sep 15:48 dist/objective-j/Frameworks/Objective-J/Objective-J.js
daboe01@MacBook-Pro-9 cappuccino % ls -la dist/objective-j/Frameworks/Debug/Objective-J/Objective-J.js
-rw-r--r-- 1 daboe01 staff 860253 23 Sep 15:48 dist/objective-j/Frameworks/Debug/Objective-J/Objective-J.js
daboe01@MacBook-Pro-9 cappuccino % ls -la /Users/daboe01/src/cappuccino/Build/Release/Objective-J/Objective-J.js
/Users/daboe01/src/cappuccino/Build/Release/Objective-J/Objective-J.js
-rw-r--r--@ 1 daboe01 staff 352208 13 Sep 14:46 /Users/daboe01/src/cappuccino/Build/Release/Objective-J/Objective-J.js

both Debug/Objective-J/Objective-J.js and Objective-J/Objective-J.js seem to be updated at the same time.
the version in build folder not so.

this is how my build log looks like:

daboe01@MacBook-Pro-9 cappuccino % jake install
(in /Users/daboe01/src/cappuccino)
(in /Users/daboe01/src/cappuccino)
(in /Users/daboe01/src/cappuccino/Objective-J)
Version: 1.3.1
Revision: df96a4e
Timestamp: 1758707650223
Build took 19 millseconds
(in /Users/daboe01/src/cappuccino/CommonJS)
Version: 1.3.1
Revision: df96a4e
Timestamp: 1758707650303
Build took 15 millseconds
(in /Users/daboe01/src/cappuccino/Foundation)
Build took 5 millseconds
(in /Users/daboe01/src/cappuccino/AppKit)
(in /Users/daboe01/src/cappuccino/AppKit/Themes)
(in /Users/daboe01/src/cappuccino/AppKit/Themes/BlendKit)
Build took 2 millseconds
(in /Users/daboe01/src/cappuccino/AppKit/Themes/CommonJS)
Build took 0 millseconds
(in /Users/daboe01/src/cappuccino/AppKit/Themes/Aristo)
Building Aristo theme
Recording themed properties for CPColor.
...

It is very strange that your build folder is not updated. Have you tried to delete the build folder and rebuild?

excellent suggestion! removing Build followed by jake install makes this PR eventually work for me :-)

from my side this is ready now.

I have one minor issue left. The function just above your iterator generator function is a CFMutableDictionary function. If you move up your function one step all CFDictionary functions will be in the same place and all CFMutableDictionary` functions will also be collected together.

Thanks! Excellent! Merged!