fix(home-manager/dunst): avoid IFD#302
Merged
getchoo merged 1 commit intocatppuccin:mainfrom Aug 15, 2024
Merged
Conversation
Contributor
Author
|
nix-community/home-manager#5710 has been merged, so this is no longer blocked. |
getchoo
approved these changes
Aug 7, 2024
Member
getchoo
left a comment
There was a problem hiding this comment.
LGTM, but I'm going to leave this open for a bit as I don't use dunst personally and would like to give others some time to give their opinion on this. Thanks!
Contributor
Author
|
Fair enough. Better safe than sorry. |
Merged
vdbe
added a commit
to vdbe/catppuccin-nix
that referenced
this pull request
Aug 15, 2024
The IFD from dunst was removed in catppuccin#302
getchoo
added a commit
that referenced
this pull request
Aug 23, 2024
* docs: add IFD FAQ * docs: mirror IFD FAQ to docs * docs: reword IFD FAQ to those ports * chore: update IFD list * chore: remove dunst from IFD list The IFD from dunst was removed in #302 * docs: FAQ IFD apply suggestions * docs: FAQ IFD add spotify-player * docs: cleanup IFD module code example Seems spotify-player doesn't required IFD either as it's source is from a builtin --------- Co-authored-by: seth <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses dunst's drop-in feature to set the theme rather than importing it into nix.
This approach has the drawback that theme settings are now potentially slightly more inconvenient to override. The theme drop-in overrides settings from
dunstrc, but it can itself be overridden by another drop-in that is after it in lexical order.I added a
prefixoption to make it more convenient to have the catppuccin drop-in appear in a certain spot in lexical order if the user has multiple drop-ins they wish to use with dunst.Currently blocked on nix-community/home-manager#5710