-
Notifications
You must be signed in to change notification settings - Fork 472
Lynx cc65 and ca65 include file improvements for Mikey and Suzy #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks ok - however, please use C style comments only |
|
Before closing, please hold till I investigate order of writes for short and long first. This is important and it seems to be different for local variables and literal values. That would break the structs in Suzy math. |
You can not rely on that, the compiler can freely choose any order - so if that kind of thing is important, you really need to write the respective code in assembly. That said, please fix the comments so this can be merged. Also please do not shuffle around stuff in header files and remove existing comments for no reason - ie produce the minimal diff. |
|
Removed the math structures and the corresponding union from the Suzy structure definition. |
There are still a bunch of c++ style comments - please use regular c-style comments instead Also, a large portion of the diff apparently covers formatting changes and typo fixes - this makes the diff very hard to read, ie to see what was actually fixed or added. Next time please keep changes to a minimum - and IF you want to do style/formatting/typo fixing, please use a separate PR for just that (ie don't mix with actual code changes). |
Named math union
55fc1a4 to
0c01891
Compare
|
Changed to C-style comments. |
thansk - you missed a few however (_mikey.h), please check those :) |
|
Do you mean the end of line comments? That was already used (in this and other places) before I submitted the PR. |
yes indeed
oh well, i see. i only see the diff of course. Still, please change them in the file(s) you touched, please |
|
Thanks! |
This set adds enumeration values and new structures to both _suzy.h and _mikey.h
Suzy changes:
Mikey changes:
It also adds new definitions in ca65 include lynx.inc.