Fix minor preprocessor problems #2518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and filename. y
…pace between a name of an object like macro and its replacement list.
|
Thanks! would you post the test anyway? I'll try adding it in misc then |
|
This test file #line 13"x"
#define X"y"
int main() { foo; }generates before the fix. After the fix, the output depends on the while it says using |
|
Oh this is a tricky one :) |
|
added the test in 7dc09fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes both issues from #2515.
I would have also added a test which was already written, but there seems to be no simple way to execute it in a way that works with the current test infrastructure.