@johnmay, one attention point is the support of Java8. Java11 was released in 2018 and is a LTS release, and last week Java17 was released the second LTS release after Java8. Dependencies are dropping Java8 support, maybe we should too?

@johnmay, is 2.8 going to be Java 11?

Tricky as we use CDK in products at NextMove and a lot of customers will still be on older systems. I think maybe we do just make the jump though. Perhaps 2.8 -> Java 8 and 2.9 Java 11?

That way I can make Java 11 advisable on the next NextMove product releases then required after that. Sound good?

We can actually make just this module Java 11 right now, since I don't use RDF/JENA it wouldn't get in the way.

@johnmay, ready to go into master.

Can work out why the pipelines have not run, do we need Java 11?

Yes, sorry, we did not migrate in the next upcoming release yet? Sorry, my bad!

Part of #823

@egonw This is good to merge then can do a release

@egonw This is good to merge then can do a release

@johnmay, I double check, update to Jena 4.5 (minor update) and then merge in, okay?

The minor update doesn't fix anything...? This is a major update.

The minor update doesn't fix anything...? This is a major update.

This is the patch I have in mind, updating to the latest dependencies (to make it just a bit more future proof, and I'm sure they fixed stuff in those libs):

diff --git a/storage/iordf/pom.xml b/storage/iordf/pom.xml
index 3fac744a51..3f5b29e04d 100644
--- a/storage/iordf/pom.xml
+++ b/storage/iordf/pom.xml
@@ -17,7 +17,7 @@
         <dependency>
             <groupId>org.apache.jena</groupId>
             <artifactId>jena-core</artifactId>
-            <version>4.4.0</version>
+            <version>4.5.0</version>
             <exclusions>
                 <exclusion>
                     <artifactId>slf4j-log4j12</artifactId>
@@ -32,7 +32,7 @@
         <dependency>
             <groupId>org.apache.jena</groupId>
             <artifactId>jena-arq</artifactId>
-            <version>4.4.0</version>
+            <version>4.5.0</version>
             <exclusions>
                 <exclusion>
                     <artifactId>slf4j-log4j12</artifactId>
@@ -47,7 +47,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-log4j12</artifactId>
-            <version>1.7.10</version>
+            <version>1.7.36</version>
             <exclusions>
                 <exclusion>
                     <groupId>log4j</groupId>

@johnmay, this PR: #867

Sorry not clear, make it 4.5.0 you mean?

Yes, 4.5 was released very recently as an update to 4.2/4.4. See the PR #867 what I mean.

Fixed

Do you merge this in, or should I?

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

50.0% Coverage
1.6% Duplication