-
Couldn't load subscription status.
- Fork 170
SMILES extension and depiction of multipart reactions #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… graphics and raster images.
…s also now scaled like bond length.
…he intermediate compounds.
…with a counter class and ensure in sequence reactions they are numbered correctly (i.e. no gaps). The highlighting should also be cleared after all the bounds are generated
|
@johnmay, WIP? |
|
Yep but will try and get bits fixed up today. |
|
Will wait for SonarCloud but should be done now. |
|
SonarCloud Quality Gate failed.
|
|
Good to go, the code smells are marginal and most already present |
|
Looks good. |
Emma in cdk/depict#33 suggest supporting multistep SMILES as
{A}>{B}>{C}>{D}>{E}is short for{A}>{B}>{C}and{C}>{D}>{E}. Importantly this single string allows us to depict them in a single image in CDK depict.We already have a reaction set model in CDK so it's simply a matter of a few minor modifications to the SMILES parsing.
The depiction was a little trickier and required cleanup to how we currently handle reactions. I'm still not convinced this is that clean, but there are a lot of pieces to position in the reaction so it's always going to be a bit finiky, particularly as I wanted the ability to optimise layout for linear sequences.
Example:
Result:
Not handled reaction/step labels yet but molecule titles/labels work well (although there is no way to get this in via SMILES:
TODO: