Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

phpfui
Copy link

@phpfui phpfui commented Jul 2, 2021

This PR cleans up a minor issue in README.md that produces a warning from w3.org. See lines 130-136 in https://validator.w3.org/nu/?doc=https%3A%2F%2Fgithub.com%2Fcebe%2Fmarkdown

The A elements don't really add anything and are not needed.

@phpfui
Copy link
Author

phpfui commented Sep 20, 2021

Any chance to get this merged?

Minor issue, but it produces HTML that does not validate. Apparently GitHub has a lot of bad html, and it changes, so look for issues 185 - 191 here: https://validator.w3.org/nu/?doc=https%3A%2F%2Fgithub.com%2Fcebe%2Fmarkdown The rest of the errors are GitHub issues. You may also be able to see just the errors in the readme.md file here: https://validator.w3.org/nu/?doc=http%3A%2F%2Fphpfui.com%2F%3Fn%3Dcebe%255Cmarkdown, but I sometimes clean them up.

Thanks!

[![Scrutinizer Quality Score](https://scrutinizer-ci.com/g/cebe/markdown/badges/quality-score.png?s=17448ca4d140429fd687c58ff747baeb6568d528)](https://scrutinizer-ci.com/g/cebe/markdown/)

What is this? <a name="what"></a>
What is this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might break existing links (i.e. the only available ID there now will be #what-is-this- instead of #what). How about changing it to <span id="what"></span> instead? That validates, and keeps existing links working. (Same for the other ones below.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't care as long as it is valid HTML. It is currently not valid. You want me to revise?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer here, so it's not my call, but I'd say it'd be best to maintain backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants