Thanks to visit codestin.com
Credit goes to github.com

Skip to content

call function with new keyword when calling classes #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

call function with new keyword when calling classes #136

wants to merge 2 commits into from

Conversation

@leso-kn
Copy link

@leso-kn leso-kn commented May 28, 2025

This PR adds support for calling constructors!

It triggers when calling a javascript class from lua. Classes are distinguished from generic functions by the .constructor-field.

Syntax:

local ws = window.WebSocket("https://example.org")

-- ws is a new instance of WebSocket
ws.send 'hello example.org!'

RodrigoDornelles
RodrigoDornelles approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@RodrigoDornelles RodrigoDornelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leso-kn leso-kn force-pushed the constructors branch 2 times, most recently from 9a32e3e to fd97b6a Compare June 12, 2025 08:22
@leso-kn
Copy link
Author

leso-kn commented Jun 12, 2025 •
edited
Loading

@ceifa @RodrigoDornelles Linter warnings should be fixed :)

(verified here: leso-kn:wasmoon run#15605367128)

@God-damnit-all God-damnit-all mentioned this pull request Jun 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RodrigoDornelles RodrigoDornelles RodrigoDornelles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leso-kn @RodrigoDornelles