Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@OliLay
Copy link
Collaborator

@OliLay OliLay commented Aug 1, 2022

Some things addressed by this PR (Simon and me worked together on this):

  • Default port changed to 3126 (unassigned IANA port)
  • Fix leftover hardcoded version
  • Enhanced debug logging
  • Set TCP timeouts on the sockets on the server side (so rogue processes should not be possible any more)
  • Fixed local compilation occurring although compilation is already running remotely

@OliLay OliLay requested review from spirsch and wmann-celonis August 1, 2022 14:34
Copy link
Collaborator

@wmann-celonis wmann-celonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you grepped for the old port number to ensure we don't miss any occurrence?

@OliLay
Copy link
Collaborator Author

OliLay commented Aug 3, 2022

I guess you grepped for the old port number to ensure we don't miss any occurrence?

Yes, exactly.

@OliLay OliLay merged commit 16ed597 into main Aug 3, 2022
@OliLay OliLay deleted the next-release-fixes branch August 3, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants