-
Notifications
You must be signed in to change notification settings - Fork 0
CPL-6548: Stateful Host Slots #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmann-celonis
approved these changes
Jun 9, 2022
k-lukas
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily adds the ability to track occupied host slots via named
POSIXsemaphores over multiplehomcccalls and therefore limit the amount of locally running compilations as well as prohibiting to try compiling onremotehosts for which we already occupy all slots:DEFAULT_LOCALHOSTif nolocalhosthost is explicitly provided.Remote/Localhost]HostSemaphorewere added for their respective remote and local compilation cases via theposix_ipclibrary:SIGINTandSIGTERMis provided via theHostSemaphorebase class (SIGKILLcannot be handled explicitly and will lead to unwanted behavior)RemoteHostSemaphoreprovides non blocking acquisition of the relevant semaphoreLocalHostSemaphoreprovides blocking acquisition of the relevant semaphore:In order to keep the order of compilation executions relatively similar to the order of when
homccprocesses were called, we currently use an "inverse exponential backoff" strategy where compilation requests wait longer in the beginning but decrease exponentially as briefly illustrated here.StateFileclass adds the basic functionality for for managingdistcc-monitoringtools compatible state files.Additional Changes:
READE.md