Add pymemcache support #9977
Open
Add pymemcache support #9977
+253
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Celery cache backend from pylibmc/python-memcached to pymemcache as the exclusive memcached client library, simplifying dependencies while maintaining backward compatibility.
Key changes:
- Replaces
import_best_memcache()/get_best_memcache()withget_memcache_client()that exclusively uses pymemcache - Implements HashClient for multiple servers and RetryingClient for configurable retry logic
- Maintains backward compatibility by accepting pylibmc-style URLs and ignoring the
behaviorsparameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| celery/backends/cache.py | Replaces multi-library detection logic with pymemcache-only implementation; adds ClientFactory with retry support |
| t/unit/backends/test_cache.py | Rewrites tests to use pymemcache mocks instead of pylibmc/python-memcached; adds new tests for retry and multi-server scenarios |
| requirements/extras/pymemcache.txt | Updates dependency from python-memcached to pymemcache>=3.4.0 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9977 +/- ##
==========================================
- Coverage 78.68% 78.68% -0.01%
==========================================
Files 153 153
Lines 19313 19326 +13
Branches 2214 2219 +5
==========================================
+ Hits 15196 15206 +10
- Misses 3817 3819 +2
- Partials 300 301 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Drop pylibmc and python-memcache and replace with pymemcache - Use pymemcache exclusively for cache backend - Add HashClient support for multiple servers - Add RetryingClient with configurable retry options - Maintain backward compatibility with pylibmc URLs - Update requirements: pymemcache>=3.4.0 - Rewrite tests for pymemcache-only implementation
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop pylibmc and python-memcache and replace with pymemcache