Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.19] REVERT: API defaults for issuer reference kind and group #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

[release-1.19] REVERT: API defaults for issuer reference kind and group #8178

merged 1 commit into from
Oct 15, 2025
+144 −124

Conversation

@cert-manager-bot
Copy link
Contributor

@cert-manager-bot cert-manager-bot commented Oct 15, 2025 •
edited by maelvls
Loading

This is an automated cherry-pick of #8173

/assign wallrj-cyberark

Revert API defaults for issuer reference kind and group introduced in 0.19.0

CyberArk tracker: VC-46124

@cert-manager-prow cert-manager-prow bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 15, 2025
@cert-manager-bot cert-manager-bot mentioned this pull request Oct 15, 2025
Merged
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2025
@wallrj-cyberark wallrj-cyberark added the cybr Used by CyberArk-employed maintainers to report to line management what's being worked on. label Oct 15, 2025
@erikgb
Copy link
Member

erikgb commented Oct 15, 2025

/test pull-cert-manager-release-1.19-make-test

wallrj-cyberark
wallrj-cyberark approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@cert-manager-prow cert-manager-prow bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 15, 2025
@wallrj
Copy link
Member

wallrj commented Oct 15, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj, wallrj-cyberark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@cert-manager-prow cert-manager-prow bot merged commit 4a63715 into cert-manager:release-1.19 Oct 15, 2025
6 checks passed
@sebastiangaiser sebastiangaiser mentioned this pull request Oct 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj-cyberark wallrj-cyberark wallrj-cyberark approved these changes

Assignees

@wallrj-cyberark wallrj-cyberark

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration cybr Used by CyberArk-employed maintainers to report to line management what's being worked on. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cert-manager-bot @erikgb @wallrj @wallrj-cyberark