1764 - migrate momentjs -> dayjs #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix cypress test bump to see if ci test passes
5e2abf3 to
301b8ed
Compare
|
|
||
| export const DATE_RANGE_MIN = '2011-12-01T12:00:00.000Z' | ||
|
|
||
| export const DATE_VALIDATION_FORMAT = 'M/D/YYYY'; |
Member
There was a problem hiding this comment.
You could add a comment above this line with a link to https://day.js.org/docs/en/display/format so it's clearer this is set by dayjs.
src/utils/__tests__/chart.spec.jsx
Outdated
| expect( res ).toContain( 'Date range: 7/14/2020 - ' ) | ||
| expect( res ).toEqual( 'Date range: 7/14/2020 - 9/30/2020' ) | ||
| // TODO: figure out why this doesn't work in CI | ||
| // expect( res ).toEqual( 'Date range: 7/14/2020 - 9/30/2020' ) |
Member
There was a problem hiding this comment.
You want to do this in another PR or this one?
Contributor
Author
There was a problem hiding this comment.
I'd do this in another one. as far as i could tell, I could never get this to work in CI even when it was using momentjs.
Contributor
Author
There was a problem hiding this comment.
Sorry, i took another look at this. Looks like some of the other cases were incorrect and i fixed up those tests and updated the logic.
Contributor
Author
There was a problem hiding this comment.
and it passes locally and in CI now!
anselmbradford
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce techical debt. get off momentjs since its deprecated and dayjs is better.
Fixed unit tests
added some validation to convert dashes to /