Print Info to functional component, print mode bug fixes #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b1aa06 to
f2cb8a3
Compare
| * @param {Function} handler - function to run | ||
| * @param {boolean} passive - if true, means function will never call preventDefault | ||
| */ | ||
| export function useEvent(event, handler, passive = false) { |
KatherynRizek
approved these changes
Oct 21, 2022
Contributor
KatherynRizek
left a comment
There was a problem hiding this comment.
Everything seems to work. The useEvent hook is a nice addition 👍
adding printinfo test updating print handler save work remove passive fixing unit tests clean up snap revert react changes fixes to print mode fixing busted tests better comments fixing broken cypress tests lint update the wait change timeout
6de74f7 to
e91f43d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Removals
Changes
components modified:
Testing
Screenshots
Notes
In development, it will crash if you click the print link in the actionBar. Production currently seems okay.
Looks like its an existing bug when opening the print dialog. Upgrading to react 18 will fix the print crash.
facebook/react#16734
Todos
Checklist