Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RefinePanel to functional #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flacoman91 merged 1 commit into from
Oct 27, 2022
Merged

RefinePanel to functional #452

flacoman91 merged 1 commit into from
Oct 27, 2022

Conversation

@flacoman91
Copy link
Contributor

@flacoman91 flacoman91 commented Oct 21, 2022 •
edited
Loading

Converts RefinePanel.js to functional components.

Additions

  • unit tests
  • added cypress test wait for filters. we should remove them when we upgrade to react 18

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@flacoman91 flacoman91 force-pushed the refinePanel branch 3 times, most recently from 70a2db1 to 6d59281 Compare October 21, 2022 18:17
@flacoman91 flacoman91 changed the title refine panel RefinePanel to functional Oct 21, 2022
@flacoman91 flacoman91 marked this pull request as ready for review October 21, 2022 18:30
@flacoman91
refine panel
6a7aaf8 
save work

debug

fixing test

cypress timepout

timeout

timeout

timeouts

bump

bump fix
@flacoman91 flacoman91 merged commit 4ac52df into main Oct 27, 2022
@flacoman91 flacoman91 deleted the refinePanel branch October 27, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KatherynRizek KatherynRizek KatherynRizek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flacoman91 @KatherynRizek