Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CCDB - Date range filters set to current date results in an empty chart area (#1866) #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrewCityBoy merged 2 commits into from
Jan 25, 2024
Merged

CCDB - Date range filters set to current date results in an empty chart area (#1866) #487

BrewCityBoy merged 2 commits into from
Jan 25, 2024

Conversation

@BrewCityBoy
Copy link
Contributor

@BrewCityBoy BrewCityBoy commented Jan 25, 2024 •
edited by contolini
Loading

Fix for Date range filters set to current date results in an empty chart area (#1866)

Jira DATAP-1216

This PR addresses the "0 matches" issue when the user selects the same date for the 'From' and 'Through' filter fields.

Changes

  • adds logic for adding the 'a-text-input__error' css class for same date selection (From & Through)

Testing

  • yarn test: All tests should pass
  • set From and Through filters as same date
  • verify the 'a-text-input__error' css class (red border) is displayed on both input fields

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@flacoman91
Copy link
Contributor

flacoman91 commented Jan 25, 2024

Nice. The date filter component also has some logic to display an error message when someone selects start date that appears after the end date.
https://github.com/cfpb/ccdb5-ui/blob/main/src/components/Filters/DateFilter.js#L43

Can you add to this "same date" check to that logic?

I think leaving the message the same is fine, or to be more complete, you could explicitly say that the From and To dates cannot be the same.

@BrewCityBoy
Copy link
Contributor Author

BrewCityBoy commented Jan 25, 2024

@flacoman91 I had some logic in there, deleted it, then forgot to add it back. Nice catch and it's been added.

flacoman91
flacoman91 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me.

@BrewCityBoy BrewCityBoy added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit c47e1fc Jan 25, 2024
@BrewCityBoy BrewCityBoy deleted the joshua_date-range-filter-error branch January 25, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flacoman91 flacoman91 flacoman91 approved these changes

@contolini contolini Awaiting requested review from contolini

@wwhorton wwhorton Awaiting requested review from wwhorton

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrewCityBoy @flacoman91