DATAP-25 fix Elasticsearch sanitization #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing ES sanitization remove isloading isfetching to cause unnecessary unmount sanitize input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: DATAP-25
Addresses: DATAP-1750
This fixes an issue causing some ES queries to fail.
To test search for savings / loan in the search bar
It should work properly.
I also removed the early exit in the search panel when the search isLoading or isFetching. This was causing the query to run repeatedly, and also hid the search bar when things failed. As a result of this, users were not able to change their query to exit the failed condition.
This is on dev5 for testing
To test:
try to search any of the following strings:
3/41/24XX/XXThis would fail on the current prod.