Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DATAP-1711 - fix Through Date mismatch #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flacoman91 merged 2 commits into from
Jun 12, 2025
Merged

DATAP-1711 - fix Through Date mismatch #582

flacoman91 merged 2 commits into from
Jun 12, 2025

Conversation

@flacoman91
Copy link
Contributor

@flacoman91 flacoman91 commented Jun 10, 2025 •
edited
Loading

The through date was using a value from metadata.js

That value is inaccurate and appears to be 1 day behind the value coming from the API.

  • I've updated the app to wait for an initial call to get the value from the API and set the MAX_DATE value.
  • Fix a react warning indicating that key should not be set through spread operators
  • Update unit tests
  • Simplified Cypress tests to not watch for network request and wait for Loading screen to end instead

To test:
Open network request tab in chrome devtools
Go to dev5
confirm you don't see any calls to metadata.js

Everything should work the same as usual

@flacoman91 flacoman91 force-pushed the DATAP-1711-max-date branch 2 times, most recently from 3075d84 to e805916 Compare June 11, 2025 20:19
@flacoman91
remove metadata.js dependency
54492bd 
fix unit tests

save work

update test

update test coverage

update cypress tests

update trends

update max_date

update dist

error handling defaults when query not ready yet

dist

update cypress

fixing a wait:

update dist
@flacoman91 flacoman91 force-pushed the DATAP-1711-max-date branch from 7c43692 to 54492bd Compare June 11, 2025 21:01
@flacoman91 flacoman91 marked this pull request as ready for review June 11, 2025 23:59
@flacoman91
Copy link
Contributor Author

flacoman91 commented Jun 11, 2025

This is on dev5 for review

higs4281
higs4281 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@higs4281 higs4281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to leave the metadata dependency behind.
Works as described.

@flacoman91 flacoman91 added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit c605d8b Jun 12, 2025
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1711-max-date branch June 12, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@higs4281 higs4281 higs4281 approved these changes

@anselmbradford anselmbradford Awaiting requested review from anselmbradford

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flacoman91 @higs4281