Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DATAP-1750 DATAP-1752 es sanitization, remove summary element #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flacoman91 merged 4 commits into from
Jun 18, 2025
Merged

DATAP-1750 DATAP-1752 es sanitization, remove summary element #583

flacoman91 merged 4 commits into from
Jun 18, 2025

Conversation

@flacoman91
Copy link
Contributor

@flacoman91 flacoman91 commented Jun 12, 2025 •
edited
Loading

Addresses: DATAP-1752, DATAP-1750
This PR:

  • removes Summary element to fix AXE warning
  • removes ES sanitization so that users can type in whatever they want in the text box

Restructure some components that were causing mount/remount on api call fail which turned into an infinite loop.

To verify:
Open Network tab in Chrome
Search for an invalid query such as: 1/4
You should only see 2 requests occurring and failing. (on production, it goes in an infinite loop)

Valid queries should still work
product:("Debt collection")

This is on dev5 for testing

@flacoman91
save work
c03f981 
cleanup error handling

update test coverage

revert

make selector better

test removing cy.waits
@flacoman91 flacoman91 force-pushed the DATAP-1750-es-sanitization branch from 158506d to c03f981 Compare June 13, 2025 02:58
@flacoman91 flacoman91 changed the title Datap 1750 es sanitization Datap-1750 es sanitization Jun 13, 2025
@flacoman91 flacoman91 marked this pull request as ready for review June 13, 2025 16:38
@flacoman91 flacoman91 enabled auto-merge June 13, 2025 16:46
@flacoman91 flacoman91 changed the title Datap-1750 es sanitization DATAP-1750 DATAP-1752 es sanitization Jun 13, 2025
@flacoman91 flacoman91 changed the title DATAP-1750 DATAP-1752 es sanitization DATAP-1750 DATAP-1752 es sanitization, remove summary element Jun 13, 2025
higs4281
higs4281 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@higs4281 higs4281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

results confirmed locally

@flacoman91 flacoman91 added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit ff21f38 Jun 18, 2025
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1750-es-sanitization branch June 18, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@higs4281 higs4281 higs4281 approved these changes

@anselmbradford anselmbradford Awaiting requested review from anselmbradford

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flacoman91 @higs4281