Merged
Conversation
5f46982 to
500677b
Compare
updating test linting, optimize imports linting
500677b to
3f434e7
Compare
higs4281
approved these changes
Jun 13, 2025
Member
higs4281
left a comment
There was a problem hiding this comment.
Unit tests and cypress tests run for me.
Nice to have an open API to test against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for general cleanup:
Waiting and mocking the responses may be faster, but by testing the actual API, we can test the API as well as the actual data.
Removing these API waits is much simpler than generating mock fixtures and listening for URL string matching.
Also, with the introduction of RTK Query, the network requests are cached so we don't need to watch and intercept data as much anymore.
To test
This PR CI frontend checks should pass
you can also do
yarn testto run the unit testsor run your local rig on localhost:3000
and run
yarn cypress run