This repository was archived by the owner on Jan 31, 2018. It is now read-only.
Bugfix for exposed @font-size var #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Trivial, but you could add the backticks around the variable name here.
Contributor
|
Update version number in |
- change to @font-size var stopped exposing var outside the mixin - there is dependent code relying on the exposed @font-size variable to simplify em based values at mobile friendly breakpoints
Contributor
|
👍 |
Scotchester
added a commit
that referenced
this pull request
Oct 5, 2015
Bugfix for exposed @font-size var
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-exposed @font-size var for code that requires it
Testing
Review
Preview this PR without the whitespace changes