Updating web type spacing and leading #53
Conversation
src/cf-base.less
Outdated
There was a problem hiding this comment.
This should probably get changed to 30 at this point.
There was a problem hiding this comment.
I don't think so because 20px matches the main headings and when we were discussing it I remember @nataliafitzgerald specifically asking me if it was 20px.
There was a problem hiding this comment.
But there's no line-height to deal with in the table/figure, and uncertain whether there is any below, too.
There was a problem hiding this comment.
So it was always wrong for table and figure? Make sure you expand the view, because this includes
p,
ul,
ol,
dl,
as well
There was a problem hiding this comment.
Oops, that's what I was missing. I think we probably should split these out into the first four and the last two, and update the last two.
|
👍 but merge conflicts |
|
Ok, @nataliafitzgerald and I have tested this thoroughly. Please update by following the adjustments made in cf-type-testing's Not reflected there, but also needing to be added to this file, is the rule for 30px between adjacent headings. Let me know if you have any questions. |
|
P.S.: Please also add the list styling as shown in that file, as well. |
- Updated text leading (line-height) to match recommendation from DM issue #349 - Updated text top and bottom margins to match recommendation from DM issue #269 - Fixed subheader font-weight - We are no longer optically adjusting margins/padding to match design mockups pixel perfectly
- Updated text leading (line-height) to match recommendation from DM issue #349 - Updated text top and bottom margins to match recommendation from DM issue #269 - Fixed subheader font-weight - We are no longer optically adjusting margins/padding to match design mockups pixel perfectly
Type sizing update updates
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Can we abbreviate this to CFPB Design Manual or include a link to the issue instead? DM is a little jargony.
|
👍 I pulled this into v1 and it looks good! |
|
👍 At long last. Thanks, @jimmynotjim! |
Updating web type spacing and leading
|
At long last indeed. Extra special thanks to @jjames @jimmynotjim and @Scotchester |
Updating web type spacing and leading
Changes
Fixes
Testing
/demo/index.htmland scroll to heading sectionbower install [email protected]:jimmynotjim/cf-core.git#d9f0266if you do this, you'll have to uninstall it and then install the regular cf-core when done testingReview
Screenshots
## Notes - We are no longer optically adjusting margins/padding to match design mockups pixel perfectly ## Checklist - [x] Changes are limited to a single goal (no scope creep) - [x] Code can be automatically merged (no conflicts) - [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end) - [ ] Passes all existing automated tests - [ ] New functions include new tests - [ ] New functions are documented (with a description, list of inputs, and expected output) - [ ] Placeholder code is flagged - [ ] Visually tested in supported browsers and devices - [ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)