This repository was archived by the owner on Nov 22, 2017. It is now read-only.
Remove default ES mapping functionality #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your ideas intrigue me and I wish to subscribe to your newsletter |
Contributor
|
Makes sense to me. |
|
LGTM 👍 |
kurtrwall
pushed a commit
that referenced
this pull request
May 6, 2015
Remove default ES mapping functionality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an Elasticsearch mapping isn't specified in the
processors.jsonfile, a default mapping is set (found in /_defaults/). This might have made sense back when we had a single post type, but now that we have a number of different post types with varying fields, this seems wrong.We should still create an explicit mapping for each doc_type, but let Elasticsearch take its best guess at a mapping in the absence of a supplied one, rather than use an incorrect mapping not meant for that doc_type.
Review: @rosskarchner @Scotchester @willbarton