This repository was archived by the owner on Nov 22, 2017. It is now read-only.
Include a non-zero exit code if indexing fails #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good and the tests pass 👍 |
Contributor
|
rock on. |
rosskarchner
added a commit
that referenced
this pull request
May 18, 2015
Include a non-zero exit code if indexing fails
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sheer consumes a
_settings/processors.jsonfile, indexing each doc type. Currently, if one of the doc types fails, an error message is printed to stderr and the process continues. This is particularly problematic when using something like Jenkins, because even though some of the doc types may have failed, the build will still be labeled as a success. If it weren't for a proactive developer skimming through the output, the unindexed doc type might go unnoticed.In this PR, we now keep track of the failing processors (if any), and exit with an exit code describing the problem. A user running
sheer indexshould see the failure message at the end, and Jenkins will know to fail the build if everything didn't index properly. If everything indexes properly, the behavior is exactly like it was before.A few formatting fixes were thrown in as well.
Review: @rosskarchner