Fix template search bug, change name of function, remove unnecessary lines #108
Conversation
|
@kurtw agreed we can hold off on merging this until Monday 6/22, due to user testing and a merge freeze on the OAH project. |
|
@kurtw are we sure that OaH is the only project that used search_with_url_arguments? |
|
Flapjack uses it. This should get in as soon as possible because it currently breaks front-end navigation after doing a query in a page that uses a filter. |
|
@kurtw I wanted to say that OaH gives this PR green light, but I didn't want to merge it and cause some other project break. So if flapjack has made the necessary update I'll merge this first thing tomorrow. |
|
@kurtw it looks like I don't have write access to this repo and can't merge the changes. |
|
You should have access now, @fna |
Fix template search bug, change name of function, remove unnecessary lines
|
@fna Have you pulled in the necessary changes for oah so that this doesn't break existing code? |
|
@kurtw I have merged your PR to owning-a-home |
|
Great! |
When searching using search_with_url_arguments from within a template, the function will take in url arguments, as well as arguments from the function. This adds a parameter to flag if that behavior is desired. The name of the function has also been changed, and needs to be updated in the repo's that use it: cfgov-refresh, owning-a-home
@dpford @rosskarchner