Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 22, 2017. It is now read-only.

Remove irrelevant print statement #116

Merged
rosskarchner merged 1 commit into from
Jul 17, 2015
Merged

Remove irrelevant print statement #116

rosskarchner merged 1 commit into from
Jul 17, 2015

Conversation

@kurtrwall
Copy link

@kurtrwall kurtrwall commented Jul 17, 2015

Print statement left in there needs to be removed.

@dpford @rosskarchner

@rosskarchner
Copy link
Contributor

rosskarchner commented Jul 17, 2015

Looks good. Can #111 have it's day in court?

rosskarchner added a commit that referenced this pull request Jul 17, 2015
@rosskarchner
Merge pull request #116 from kurtw/master
aafe5e6 
Remove irrelevant print statement
@rosskarchner rosskarchner merged commit aafe5e6 into cfpb:master Jul 17, 2015
@rosskarchner
Copy link
Contributor

rosskarchner commented Jul 17, 2015

Any reason this would have broken tests?

======================================================================
FAIL: `sheer index`
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/sheer/test_indexing.py", line 87, in test_indexing
    self.mock_processor.documents())
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 835, in assert_called_with
    raise AssertionError(msg)
AssertionError: Expected call: bulk(<MagicMock name='Elasticsearch()' id='139818875916368'>, <listiterator object at 0x7f2a1e73c150>)
Actual call: bulk(<MagicMock name='Elasticsearch()' id='139818875916368'>, <listiterator object at 0x7f2a1e73c150>, index='content')
-------------------- >> begin captured stdout << ---------------------
creating mapping for posts (posts_processor)
indexed <MagicMock name='bulk().__getitem__()' id='139818875649552'> posts 

--------------------- >> end captured stdout << ----------------------

======================================================================
FAIL: `sheer index`
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/sheer/test_indexing.py", line 275, in test_indexing_failure_ioerr
    self.mock_processor.documents())
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 835, in assert_called_with
    raise AssertionError(msg)
AssertionError: Expected call: bulk(<MagicMock name='Elasticsearch()' id='139818875120976'>, <listiterator object at 0x7f2a1e679c90>)
Actual call: bulk(<MagicMock name='Elasticsearch()' id='139818875120976'>, <listiterator object at 0x7f2a1e679c90>, index='content')
-------------------- >> begin captured stdout << ---------------------
creating mapping for ioerrs (posts_processor)
indexed <MagicMock name='bulk().__getitem__()' id='139818874912080'> ioerrs 
creating mapping for posts (posts_processor)
indexed <MagicMock name='bulk().__getitem__()' id='139818874912080'> posts 

--------------------- >> end captured stdout << ----------------------

======================================================================
FAIL: `sheer index --processors posts`
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/sheer/test_indexing.py", line 167, in test_partial_indexing
    self.mock_processor.documents())
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 835, in assert_called_with
    raise AssertionError(msg)
AssertionError: Expected call: bulk(<MagicMock name='Elasticsearch()' id='139818875647312'>, <listiterator object at 0x7f2a1e6a7b10>)
Actual call: bulk(<MagicMock name='Elasticsearch()' id='139818875647312'>, <listiterator object at 0x7f2a1e6a7b10>, index='content')
-------------------- >> begin captured stdout << ---------------------
indexed <MagicMock name='bulk().__getitem__()' id='139818875053968'> posts 

--------------------- >> end captured stdout << ----------------------

======================================================================
FAIL: `sheer index --processors posts --reindex`
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/sheer/test_indexing.py", line 207, in test_partial_reindexing
    self.mock_processor.documents())
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 835, in assert_called_with
    raise AssertionError(msg)
AssertionError: Expected call: bulk(<MagicMock name='Elasticsearch()' id='139818874787344'>, <listiterator object at 0x7f2a1e5ed810>)
Actual call: bulk(<MagicMock name='Elasticsearch()' id='139818874787344'>, <listiterator object at 0x7f2a1e5ed810>, index='content')
-------------------- >> begin captured stdout << ---------------------
removing existing mapping for posts (posts_processor)
creating mapping for posts (posts_processor)
indexed <MagicMock name='bulk().__getitem__()' id='139818874699856'> posts 

--------------------- >> end captured stdout << ----------------------

======================================================================
FAIL: `sheer index --reindex`
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/sheer/test_indexing.py", line 126, in test_reindexing
    self.mock_processor.documents())
  File "/var/lib/jenkins/jobs/cf.gov-sheer-unit-tests/workspace/.env/lib/python2.7/site-packages/mock.py", line 835, in assert_called_with
    raise AssertionError(msg)
AssertionError: Expected call: bulk(<MagicMock name='Elasticsearch()' id='139818874385936'>, <listiterator object at 0x7f2a1e54b710>)
Actual call: bulk(<MagicMock name='Elasticsearch()' id='139818874385936'>, <listiterator object at 0x7f2a1e54b710>, index='content')
-------------------- >> begin captured stdout << ---------------------
reindexing content
creating mapping for posts (posts_processor)
indexed <MagicMock name='bulk().__getitem__()' id='139818874498896'> posts 

--------------------- >> end captured stdout << ----------------------

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kurtrwall @rosskarchner