Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 4, 2021. It is now read-only.

Conversation

@niqjohnson
Copy link
Member

Currently the Spanish version of the "About this tool" page shows the English mega-menu; it should show the Spanish mega-menu. (See GHE/CFGOV/platform/issues/3912 for more details.)

The about page just needed the same fix as we made in #259

Additions

  • language key to the about page

Testing

  1. Install this version of the retirement app in cf.gov using the method of your choice
  2. Go to /consumer-tools/retirement/before-you-claim/about/es/ and make sure the Spanish version of the mega-menu appears (and that all the other Spanish content continues to appear)
  3. Go to /consumer-tools/retirement/before-you-claim/about/ and make sure the English version of the mega-menu continues to appear

Screenshots

es-about-page

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests

Currently the Spanish version of the "About this tool" page shows the English
mega-menu; it should show the Spanish mega-menu.

The about page just needed the same fix as we made in
#259
@niqjohnson niqjohnson requested review from chosak and higs4281 October 16, 2020 21:13
Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised.

@niqjohnson niqjohnson merged commit a6b4fc8 into main Oct 19, 2020
@niqjohnson niqjohnson deleted the fix-es-about branch October 19, 2020 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants