Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 4, 2021. It is now read-only.

Conversation

@Scotchester
Copy link
Contributor

@Scotchester Scotchester commented Jan 28, 2021

In conjunction with a forthcoming PR to consumerfinance.gov, these will enable the banner on Beta and requesting the Spanish mega menu explicitly instead of relying on a default.

Additions

  • Context variables show_banner and show_mega_menu on the claiming and about views

Testing

[To be filled in once related cf.gv PR is open.]

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool ➡️

In conjunction with a forthcoming PR to consumerfinance.gov, these will 
enable the banner on Beta and requesting the Spanish mega menu 
explicitly instead of relying on a default.
Copy link
Member

@higs4281 higs4281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me in local env.

@Scotchester Scotchester merged commit ea74520 into main Feb 1, 2021
@Scotchester Scotchester deleted the add-context-vars branch February 1, 2021 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants