Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@marineharel
Copy link
Collaborator

@marineharel marineharel commented Apr 28, 2025

Description

Multiphysic DEM simulations can now be launched with solver type dem_mp to follow the evolution of the temperature of the particles.
Temperature is also added in the properties printed by application tests for solver type dem_mp.

Testing

An application test is added, it is the same as the packing_in_ball test but it uses multiphysic DEM.

Documentation

The documentation for multiphysic DEM will be added in a future PR.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • New feature has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Nothing to say or add.
Could you please add a changelog ? :) Then I would merge it :)

@blaisb blaisb added Ready to merge after CHANGELOG/Rebase This PR is ready to merge once the CHANGELOG file has been updated. and removed Ready for review labels Apr 29, 2025
@marineharel marineharel added Reviewed and ready to merge and removed Ready to merge after CHANGELOG/Rebase This PR is ready to merge once the CHANGELOG file has been updated. labels Apr 30, 2025
@blaisb blaisb merged commit e610669 into master Apr 30, 2025
9 checks passed
@blaisb blaisb deleted the add_demmp_solver branch April 30, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants