Fix vof initial condition geometric smoothing #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
reviewed
Oct 14, 2025
blaisb
approved these changes
Oct 14, 2025
AmishgaAlphonius
approved these changes
Oct 14, 2025
Co-authored-by: Bruno Blais <[email protected]>
a99650e to
939a88b
Compare
OresteMarquis
pushed a commit
that referenced
this pull request
Oct 30, 2025
Description There was a seg fault when the geometric smoother was selected in the vof initial condition with a reinitialization method other than the geometric one. It was because the SignedDistanceSolver was only instantiated if the geometric reinitialization method was selected. Solution Add the instantiation of the SignedDistanceSolver if the geometric smoother is selected in the vof initial condition. Testing The segmentation fault doesn't happen anymore. Documentation No new parameters for now, but the documentation was updated to specify that the initial condition geometric smoother parameters are declares in the reinitialization method subsection. Co-authored-by: Bruno Blais <[email protected]>
OresteMarquis
pushed a commit
that referenced
this pull request
Oct 31, 2025
Description There was a seg fault when the geometric smoother was selected in the vof initial condition with a reinitialization method other than the geometric one. It was because the SignedDistanceSolver was only instantiated if the geometric reinitialization method was selected. Solution Add the instantiation of the SignedDistanceSolver if the geometric smoother is selected in the vof initial condition. Testing The segmentation fault doesn't happen anymore. Documentation No new parameters for now, but the documentation was updated to specify that the initial condition geometric smoother parameters are declares in the reinitialization method subsection. Co-authored-by: Bruno Blais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a seg fault when the geometric smoother was selected in the vof initial condition with a reinitialization method other than the geometric one. It was because the SignedDistanceSolver was only instantiated if the geometric reinitialization method was selected.
Solution
Add the instantiation of the SignedDistanceSolver if the geometric smoother is selected in the vof initial condition.
Testing
The segmentation fault doesn't happen anymore.
Documentation
No new parameters for now, but the documentation was updated to specify that the initial condition geometric smoother parameters are declares in the reinitialization method subsection.
Miscellaneous (will be removed when merged)
It's a quick fix, it's not ideal, but the parameters are not repeated.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: