feat: set reqwest to default-features = false #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for you attention @chenhunghan ! Glad to discuss further |
|
Thank you, I think it's ok to be a minor version since it hasn't been to v1 yet. I will merge and release. |
|
Appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm in the process of trying to get OpenSSL out of my dependency closure, in favor of
rustls.Currently
jwksimplicitly enables all default features ofreqwest, which implicitly enableshyper-tls,openssl-sys, etc.It would be great if it could have the default features disabled so that the caller can pick which backend to include.
This is technically a potentially breaking change, if both of the following criteria apply:
I'd be glad to cut this as a feature flag instead, or as a version bump. Open to suggestions!