Be more specific (and liberal) with Ruby version requirements #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a537c4f to
cff316c
Compare
julik
added a commit
that referenced
this pull request
Apr 1, 2025
cff316c to
c659df3
Compare
ActiveRecord connection management can be tricky, and we don't need it as such - we need to _integrate_ with it well. Also, all of our queries are .uncached. We do still want the queries to go through ActiveRecord adapters, because there is useful instrumentation in their `execute` which some folks are using Relocate sanitization into the shim as well, for future work
c659df3 to
3650da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is zero issue with supporting 2.7 and older Rails, we just need to carefully figure out how to handle AR connections in tests and how to dissociate our calls from ActiveRecord well. Nothing that Pecorino does (aside from migration format) is ActiveRecord specific, but we still want to integrate well with ActiveRecord.
And it is reasonable for Pecorino to have the minimum requirement tested by default.