Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 22, 2023

(doc)

Description Of Changes

Fixed some minor typos and spelling errors.

Motivation and Context

Improve code quality and documentation legibility.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2023

CLA assistant check
All committers have signed the CLA.

@gep13 gep13 added this to the 2.0.0 milestone Jan 24, 2023
@gep13 gep13 changed the title fix typos and spelling errors (doc) Fix typos and spelling errors Jan 24, 2023
@gep13
Copy link
Member

gep13 commented Jan 24, 2023

@sinapis-amicus thank you very much for taking the time to find, and also to correct, these spelling mistakes!

I have left one comment regarding one of the changes you have suggested, can you let me know what you think?

Also, can you update the commit message for the commit to include (doc) at the start of the line? This would be in-keeping with our standard commit message formatting.

@ghost ghost requested a review from gep13 January 24, 2023 19:27
@gep13
Copy link
Member

gep13 commented Jan 25, 2023

@sinapis-amicus actually, I won't be able to push the changes back to this PR branch, since you haven't created the PR from a branch on your fork, but rather directly from your develop branch. The contributing document explains the process that we like to see folks following when suggesting changes to this repository.

Since I have already made them changes locally, including rebasing the 3 commits here into a single PR, I will go ahead and merge that directly, and close this PR. Your contributions will still be correctly attributed to you, it is just that the commits won't be coming from this PR.

Thanks again for your help in fixing these spelling mistakes, appreciate it!

@gep13 gep13 closed this Jan 25, 2023
@gep13
Copy link
Member

gep13 commented Jan 25, 2023

This PR has been rebased and merged into the develop branch here: f2b0590

@ghost
Copy link
Author

ghost commented Jan 25, 2023

@sinapis-amicus actually, I won't be able to push the changes back to this PR branch, since you haven't created the PR from a branch on your fork, but rather directly from your develop branch. The contributing document explains the process that we like to see folks following when suggesting changes to this repository.

Since I have already made them changes locally, including rebasing the 3 commits here into a single PR, I will go ahead and merge that directly, and close this PR. Your contributions will still be correctly attributed to you, it is just that the commits won't be coming from this PR.

Thanks again for your help in fixing these spelling mistakes, appreciate it!

Thanks Gary.

Happy New Year

@gep13
Copy link
Member

gep13 commented Jan 25, 2023

@sinapis-amicus said...
Thanks Gary.

Happy New Year

You are very welcome! And to you!

@gep13 gep13 changed the title (doc) Fix typos and spelling errors Fix typos and spelling errors May 19, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants