[#42] Support stack #51
Conversation
chshersh
left a comment
There was a problem hiding this comment.
Looks neat! 👍🏻
I see that CI pass which is great. And I have a few suggestions to refine the stack configuration 🧹
.github/workflows/ci.yml
Outdated
| ghc: ["9.2.3"] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
The latest version of this action is v3 so let's use it
| - uses: actions/checkout@v2 | |
| - uses: actions/checkout@v3 |
.github/workflows/ci.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: haskell/actions/[email protected] |
There was a problem hiding this comment.
Let's use the same version of Haskell action as for cabal jobs
| - uses: haskell/actions/setup@v1.2 | |
| - uses: haskell/actions/setup@v2.0 |
.github/workflows/ci.yml
Outdated
| ghc-version: ${{ matrix.ghc }} | ||
| stack-version: ${{ matrix.stack }} | ||
|
|
||
| - uses: actions/cache@v2 |
There was a problem hiding this comment.
The same as checkout, we can update it. Dependabot can update later but let's update straight away because we know newer versions already 🙂
| - uses: actions/cache@v2 | |
| - uses: actions/cache@v3 |
stack.yaml
Outdated
| - hspec-2.10.0@sha256:2d1dc53e361998f002497b7222fdb700cc540b2aaf880e2619a0b5d54abb74e5,1712 | ||
| - hspec-core-2.10.0@sha256:a5d7d3e7bbcf42e8def370d86ab08252821be6fb9d00dddb3c484973d7a6e801,6617 | ||
| - hspec-discover-2.10.0@sha256:517d0892217539969c199f9cc30065db7bcd68ff5512095e4f94ff8ef35d1313,2166 |
There was a problem hiding this comment.
I see that this snapshot contains hspec* libraries but with the version 2.9.7
Let's remove these 3 lines from stack.yaml and relax the lower bound for hspec in our test suite to allow version 2.9.7
Line 127 in e79fdc2
I expect that our project should still build and work with the lower version of hspec but this way we'll reduce the extra-deps burden for stack
|
Done! Changed versions of the actions in CI and relaxed the hspec version constraints. |
Uses this fork for colourista, and also some hspec versions are specified in extra-deps