Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Attempt to fix #56 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chshersh merged 7 commits into from
Sep 28, 2022
Merged

Attempt to fix #56 #68

chshersh merged 7 commits into from
Sep 28, 2022

Conversation

@CThuleHansen
Copy link
Contributor

@CThuleHansen CThuleHansen commented Sep 21, 2022 •
edited
Loading

This pull-request verifies the options presented in the help description and is a first go of #56.
Let me know if more has to be added

@CThuleHansen CThuleHansen mentioned this pull request Sep 21, 2022
Closed
3 tasks
@chshersh chshersh added test cli-options CLI options, parsers labels Sep 22, 2022
chshersh
chshersh requested changes Sep 22, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation! 🥇

I have a few suggestions for improving the code further. But it's a great start 👍🏻

@CThuleHansen
Copy link
Contributor Author

CThuleHansen commented Sep 23, 2022 •
edited
Loading

There is something up with this ParserFailure. If I run https://github.com/CThuleHansen/iris/blob/main/test/Test/Iris/Cli.hs#L49 with --version, then I still get a ParserFailure, but with the correct version (0.0.0.0). I was expecting a Success.

Ahh https://hackage.haskell.org/package/optparse-applicative-0.17.0.0/docs/Options-Applicative.html#v:infoOption

An option that always fails and displays a message.

Wonder why it is encoded as a failure

chshersh
chshersh reviewed Sep 23, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks pretty cool ✨

I have a few minor last comments. But all the changes are looking pretty good 🙂

Also not sure why the expected behaviour was encoded as Failure. I can come up with the reason to justify it but I'd rather want it to be something like Info and not Failure. But it is what it is.

@CThuleHansen
Copy link
Contributor Author

CThuleHansen commented Sep 28, 2022

I think it is all adressed now :)

@chshersh chshersh added the hacktoberfest-accepted https://hacktoberfest.com/participation/ label Sep 28, 2022
chshersh
chshersh approved these changes Sep 28, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! Looks really great 🏆

@chshersh chshersh merged commit 1bede5f into chshersh:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@CThuleHansen CThuleHansen

Labels

cli-options CLI options, parsers hacktoberfest-accepted https://hacktoberfest.com/participation/ test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CThuleHansen @chshersh