Add HLint #70
Add HLint #70
Conversation
chshersh
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @blackheaven!
I have a few questions and suggestions to clarify the proper CI configuration though
.github/workflows/hlint.yml
Outdated
| - name: 'Set up HLint' | ||
| uses: rwe/actions-hlint-setup@v1 | ||
| with: | ||
| version: '3.1.6' | ||
|
|
||
| - name: 'Run HLint' | ||
| uses: rwe/actions-hlint-run@v2 | ||
| with: | ||
| path: '["src/", "test/"]' | ||
| fail-on: warning |
There was a problem hiding this comment.
I haven't used rwe/actions-hlint-setup and rwe/actions-hlint-run actions before.
I would prefer to use official Haskell actions under the haskell github org:
But even then, I'm not sure what is the difference between those two actions and a simple job that just downloads the hlint executable and runs it. I used to configure hlint before with this simple setup:
There was a problem hiding this comment.
IIUC:
rwe/actions-hlint-setupdeals with the subtleties of the underlying OS (ie. download leexeon windows, and on)rwe/actions-hlint-runonly run hlint on the new/changed files
I update the PR according to your feedback, I'm open to new comments/requests.
chshersh
left a comment
There was a problem hiding this comment.
@blackheaven Thanks a lot for the contribution! I agree that we can always improve the action further if we find lacking something but for now we can start with the simplest thing that works 🙂
I'm trying to tackle #63