ci: add stan configuration #79
Conversation
|
https://github.com/chshersh/iris/actions/runs/3179437079/jobs/5186960223 job in this repository |
chshersh
left a comment
There was a problem hiding this comment.
Looks fantastic!
I have a few further suggestions 🙂
Also, let's remove the .stan.toml file. It's not needed if it's empty. We can always create it later when we need some custom configuration 🙂
| ./hlint-${HLINT_VERSION}/hlint src/ test/ | ||
| stan: | ||
| name: stan |
There was a problem hiding this comment.
Can we add a GHC version to the name to quickly see what GHC is used?
| name: stan | |
| name: stan / ghc ${{ env.GHC_VERSION }} |
There was a problem hiding this comment.
Looks like env is not accessible on jobs.<job_id>.name 😢
https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
Error on my fork: https://github.com/german1608/iris/actions/runs/3202338434/workflow
For now, we could hardwire the GHC version?
chshersh
left a comment
There was a problem hiding this comment.
I see that CI is failing currently. Probably, only the name change is required to fix it. And it's good to go 🙂
Closes #64
The only warning we are getting is from the autogenerated files, as described on #64 (comment).
You can take a look at how does the action looks on my fork:
https://github.com/german1608/iris/actions/runs/3179426624/jobs/5181906133#step:10:1