[#84] Add support for GHC 9.4.2 #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Workflow execution sample on my fork: https://github.com/german1608/iris/actions/runs/3202513553 |
chshersh
requested changes
Oct 7, 2022
Owner
chshersh
left a comment
There was a problem hiding this comment.
Thanks for improving this! I'm glad to see that not many code or dependency changes were required 🙂
Only a few things left to improve and it's good to go 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84
Adds support for GHC 9.4.2. Additionally, the
colouristapackage declaration was updated so for cabal installs it uses the new hackage version (0.1.0.2) which supports 9.2.4, and also has a convenient base bound. Forstack, I couldn't find a stackage for it, so I just pinned the commit from kowainik/colourista@c7b0681I also added Cabal 3.8 and GHC 9.4.2 to the build matrix for the cabal job. Let me know if we can just replace the existing cabal 3.6 with 3.8, or if it's okay to use both.
Additional tasks