[#59] add tests for catching global and local parser conflicts #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
reviewed
Oct 11, 2022
Owner
chshersh
left a comment
There was a problem hiding this comment.
@zetkez Thanks a lot for adding these tests!
I agree with the needed refactoring for this module but can't come up with a nice structure at the moment 🤔 Moving into a separate spec function would be a good first step though 👍🏻
Happy to merge the PR once this minor refactoring is done and conflicts with the main branch are resolved
c4d5bec to
36328fe
Compare
Contributor
Author
|
@chshersh i moved the tests to its own spec function and moved the code down inside the file. I sadly managed to loose your review comments while doing a force push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59
I added a few tests to demonstrate the conflicts between the local and global parser. The tests are by no means exhaustive, especially the tests using a optparse-applicative command. I put everything into the existing files and functions and now the code looks a bit crammed to me. Would it make sense to transfer it to a new file or at least create a new :: Spec function?
Also i did some tiny refactoring.
First time ever contributing to a Haskell project and feedback is much appreciated.
Additional tasks