Merged
Conversation
This was referenced Aug 17, 2022
ac50206 to
a4e4df8
Compare
tony
added a commit
to cihai/unihan-etl
that referenced
this pull request
Aug 21, 2022
**#257, cihai/unihan-db#298, cihai/cihai#324, cihai/cihai-cli#277 Ramp up type safety / create a typed library
55c73b1 to
be7f415
Compare
4f3f186 to
47c239c
Compare
3451d3c to
d9ad27f
Compare
Closed
66290da to
390e891
Compare
8c21093 to
36051ae
Compare
e7bf951 to
32a09a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 84.03% 84.75% +0.72%
==========================================
Files 18 21 +3
Lines 526 702 +176
==========================================
+ Hits 442 595 +153
- Misses 84 107 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7ba0755 to
d181107
Compare
~/.cache/pypoetry/virtualenvs/cihai-v-ARjhsq-py3.11/lib/python3.11/site-packages/_pytest/pathlib.py:587: in import_path
raise ImportPathMismatchError(module_name, module_file, path)
E _pytest.pathlib.ImportPathMismatchError: ('types', '~/.config/asdf/installs/python/3.11.0/lib/python3.11/types.py', PosixPath('~/work/cihai/cihai/src/cihai/_internal/types.py'))
tests/conftest.py: error: Duplicate module named "conftest" (also at "conftest.py") tests/conftest.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info tests/conftest.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH
make monkeytype_create monkeytype_apply black isort
pyupgrade src/cihai/**/*.py tests/**/*.py --py37-plus; make black ruff
Closed
tony
added a commit
to cihai/unihan-etl
that referenced
this pull request
Sep 2, 2023
**#257, cihai/unihan-db#298, cihai/cihai#324, cihai/cihai-cli#277 Ramp up type safety / create a typed library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cihai/unihan-etl#257, cihai/unihan-db#298, #324, cihai/cihai-cli#277
Ramp up type safety / create a typed library
Fixes #321