Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ameliav
Copy link
Contributor

@ameliav ameliav commented Oct 24, 2025

πŸ—£ Description

Handle Error Messaging and VS Dashboard display for two specific Null Data use cases
CRASM-3008
CRASM-3267

πŸ’­ Motivation and context

As a user, I want to receive clear and informative error messages when data is missing or unavailable, so that I understand what went wrong and can decide on the next steps.

πŸ§ͺ Testing

Use below acceptance criteria to determine how to test:

  • If null data is encountered (but there is assets owned and hosts scanned):
  • Display an error message that explains the issue in plain language.
  • Display "--" instead of a 0 for assets owned or assets scanned if the organization is over 2 weeks old.
  • Return standardized error messages.

πŸ“· Screenshots (if appropriate)

If there are assets owned and hosts scanned and nothing else as a standard user and then as a admin or global view user

image image

If there are assets owned and no hosts scanned and nothing else as a standard user and then as a admin or global view user

image image

If there's even one vulnerability, the alert will disappear and the normal dashboard will appear.
image

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@ameliav ameliav self-assigned this Oct 24, 2025
@ameliav ameliav changed the title DRAFT - Add null use case to VS Dashboard CRASM-3008 - Add new null use case display to VS Dashboard Oct 27, 2025
@ameliav ameliav marked this pull request as ready for review October 28, 2025 14:07
Copy link
Contributor

@jsalinasnttdata jsalinasnttdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. Please note I have not tested the changes locally.

@ameliav ameliav changed the title CRASM-3008 - Add new null use case display to VS Dashboard CRASM-3008 - Add new null use case alerts to VS Dashboard Nov 3, 2025
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the changes per comments

@cduhn17 cduhn17 merged commit 0f58ecf into develop Nov 3, 2025
17 of 18 checks passed
@cduhn17 cduhn17 deleted the vs-dash-page-level-null-errors-3008 branch November 3, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants