-
Notifications
You must be signed in to change notification settings - Fork 15
CRASM-3008 - Add new null use case alerts to VS Dashboard #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsalinasnttdata
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good. Please note I have not tested the changes locally.
cduhn17
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the changes per comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π£ Description
Handle Error Messaging and VS Dashboard display for two specific Null Data use cases
CRASM-3008
CRASM-3267
π Motivation and context
As a user, I want to receive clear and informative error messages when data is missing or unavailable, so that I understand what went wrong and can decide on the next steps.
π§ͺ Testing
Use below acceptance criteria to determine how to test:
π· Screenshots (if appropriate)
If there are assets owned and hosts scanned and nothing else as a standard user and then as a admin or global view user
If there are assets owned and no hosts scanned and nothing else as a standard user and then as a admin or global view user
If there's even one vulnerability, the alert will disappear and the normal dashboard will appear.

β Pre-approval checklist
bump_versionscript if this repository is versioned and the changes in this PR warrant a version bump.β Pre-merge checklist
β Post-merge checklist