Codecov Report

Merging #1648 (66477cf) into master (2463517) will decrease coverage by 1.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   86.13%   85.03%   -1.10%     
==========================================
  Files          61       61              
  Lines        2423     2453      +30     
  Branches      138      145       +7     
==========================================
- Hits         2087     2086       -1     
- Misses        336      367      +31     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2463517...66477cf. Read the comment docs.

Thanks for the PR. Love the idea. What do you think of changing the signature though to be a little more flexible.

From:
def traverseBoolean[F[_]](f: Boolean => F[Boolean])(implicit F: Applicative[F]): F[Json]

To:
def traverseBoolean[F[_]](f: Boolean => F[Json])(implicit F: Applicative[F]): F[Json]

I think this would allow more transformation within the monadic context. This would make it more akin to the with* methods than the map* methods, but you get a greater flexibility.

I think this would a nice set of combinators to have, @sergeykolbasov are you willing to make the changes suggested by @zarthross ?

The boolean case is an example, it would be the same for all the new traverseX functions

mimaErrors are genuine. We do not have these in previous releases, so we need to add exclusions rules here.

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 85.03%. Comparing base (2e435be) to head (66477cf).

❗ Current head 66477cf differs from pull request most recent head f9c23f4

Please upload reports for the commit f9c23f4 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                Coverage Diff                @@
##           series/0.14.x    #1648      +/-   ##
=================================================
- Coverage          85.13%   85.03%   -0.10%     
=================================================
  Files                 76       61      -15     
  Lines               2772     2453     -319     
  Branches             369      145     -224     
=================================================
- Hits                2360     2086     -274     
+ Misses               412      367      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.