feat(resource_snapshot): add ResourceSnapshotRestore and InstanceRestoreInfo types for restore operation response #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oreInfo types for restore operation response
…t new response structure with detailed instance information
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new types (ResourceSnapshotRestore and InstanceRestoreInfo) and updates the restore operation response handling to reflect the new structure.
- Adds new types and fields to represent restore operation responses.
- Updates both the client function and corresponding tests to use the new response structure.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| resource_snapshot_test.go | Updates tests to assert on the new Instance field in the response |
| resource_snapshot.go | Implements new response types and updates the restore function signature |
Comments suppressed due to low confidence (1)
resource_snapshot_test.go:167
- [nitpick] Consider adding assertions for 'IncludeVolumes' and 'OverwriteExisting' fields to provide comprehensive test coverage of the new restore response structure.
if got.Instance.Name != "restored-snapshot-op-name" {
Co-authored-by: Copilot <[email protected]>
giornetta
requested changes
May 12, 2025
…eRestoreInfo and update related test
giornetta
approved these changes
May 12, 2025
uzaxirr
added a commit
that referenced
this pull request
May 13, 2025
…oreInfo types for restore operation response (#256) * feat(resource_snapshot): add ResourceSnapshotRestore and InstanceRestoreInfo types for restore operation response * test(resource_snapshot): update TestRestoreResourceSnapshot to reflect new response structure with detailed instance information * Update resource_snapshot.go Co-authored-by: Copilot <[email protected]> * refactor(resource_snapshot): remove IncludeVolumes field from InstanceRestoreInfo and update related test --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #252