feat(client): enhance sendRequest to include region parameter for all HTTP methods #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… applicable HTTP methods
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the sendRequest function in client.go by including a region parameter in the request URL for additional HTTP methods.
- Expanded the condition to cover POST, PUT, and PATCH requests
- Added comments to clarify that the region parameter is conditionally appended only when applicable
| // add the region param | ||
| // Add the region param for all methods that might require it. | ||
| // It's generally safe to add as an unused query param if not needed by a specific endpoint. | ||
| if req.Method == "GET" || req.Method == "DELETE" || req.Method == "POST" || req.Method == "PUT" || req.Method == "PATCH" { |
There was a problem hiding this comment.
The current condition checks only a subset of HTTP methods while the PR title suggests inclusion for all methods. Consider either updating the title to reflect the limited scope of methods or extending the logic to handle all HTTP methods (e.g., HEAD, OPTIONS) if needed.
giornetta
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.