Refactor UpdateInstanceAllowedIPs to send structured JSON payload #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (c *Client) UpdateInstanceAllowedIPs(id string, allowedIPs []string) (*SimpleResponse, error) { | ||
| resp, err := c.SendPutRequest(fmt.Sprintf("/v2/instances/%s/allowed_ips", id), allowedIPs) | ||
| // Create a map to match the expected JSON structure | ||
| payload := map[string][]string{ |
Member
There was a problem hiding this comment.
why the payload is a generic map instead of a struct?
Contributor
Author
There was a problem hiding this comment.
beacuse the API expects it in this format.
{"Message":{"code":"invalid_request_body","reason":"Invalid request body","details":"Field should be of type map[string]interface {}, but array was provided"},"status":400}
above is the error i get from the SDK before modification.
| // UpdateInstanceBandwidth sets the list of IP addresses that an instance is allowed to use | ||
| func (c *Client) UpdateInstanceBandwidth(id string, bandwidthLimit int) (*SimpleResponse, error) { | ||
| resp, err := c.SendPutRequest(fmt.Sprintf("/v2/instances/%s/network_bandwidth_limit", id), bandwidthLimit) | ||
| payload := map[string]int{ |
alessandroargentieri
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.