Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(html5_video): ensure loop configured #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2019
Merged

fix(html5_video): ensure loop configured #1841

merged 2 commits into from
Aug 9, 2019

Conversation

@kslimani
Copy link
Contributor

@kslimani kslimani commented Aug 9, 2019

It should fix #1840.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 78.574% when pulling e4b371f on kslimani:fix-html5-loop into 905b799 on clappr:dev.

towerz
towerz approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@towerz towerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kslimani I think we should go with this solution. We can open a new issue/PR to discuss whether we need to configure more playback properties.

@towerz towerz merged commit c32f319 into clappr:dev Aug 9, 2019
@kslimani kslimani deleted the fix-html5-loop branch August 9, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandromoreira leandromoreira leandromoreira approved these changes

@towerz towerz towerz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Question about dynamic loop flag change

4 participants

@kslimani @coveralls @leandromoreira @towerz