Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clerk android missing dependency #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolfand merged 3 commits into from
Dec 15, 2025
Merged

Clerk android missing dependency #424

swolfand merged 3 commits into from
Dec 15, 2025
+1 −1

Conversation

@swolfand
Copy link
Collaborator

@swolfand swolfand commented Dec 15, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Corrects a missing dependency issue in the clerk-android-ui library's published POM. The clerk-android-telemetry dependency was incorrectly referenced without its platform suffix.

This change adds a withXml block to source/ui/build.gradle.kts to rewrite the artifactId from clerk-android-telemetry to clerk-android-telemetry-android in the generated POM, aligning with the actual artifact published by the Kotlin Multiplatform telemetry module.

Linear Issue: MOBILE-363

Open in Cursor Open in Web

Summary by CodeRabbit

  • Chores
    • Updated the publishing configuration in the release workflow to adjust Maven Central publication targets for improved build consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@cursor
Copy link

cursor bot commented Dec 15, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@swolfand swolfand marked this pull request as ready for review December 15, 2025 18:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

📝 Walkthrough

Walkthrough

The pull request modifies the manual release workflow in .github/workflows/manual-release.yml. It updates the Gradle publish command for the telemetry module from publishAndroidPublicationToMavenCentralRepository to publishAllPublicationsToMavenCentralRepository. This change expands which publications are included when publishing to Maven Central during the release process. The surrounding workflow logic and error handling remain unchanged, and no public API signatures are affected.

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title describes fixing a missing dependency issue in Clerk Android, which aligns with the primary change in the PR modifying the POM dependency reference.
Description check ✅ Passed The PR description provides a clear summary of changes, explains the dependency issue and solution, and includes a linked issue reference as per the template requirements.
Linked Issues check ✅ Passed The PR successfully addresses the objective from MOBILE-363 by resolving the missing dependency issue through POM rewriting to correctly reference the telemetry artifact with its platform suffix.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the missing dependency issue in MOBILE-363; no out-of-scope modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between feed12c and 98e9bb9.

📒 Files selected for processing (1)
  • .github/workflows/manual-release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: verify
  • GitHub Check: test-module (:source:ui, source/ui, source-ui)
  • GitHub Check: test-module (:source:api, source/api, source-api)
  • GitHub Check: build-module (:source:ui)
  • GitHub Check: build-module (:source:api)
🔇 Additional comments (1)
.github/workflows/manual-release.yml (1)

163-163: Verify the scope change for telemetry publications.

The change from publishAndroidPublicationToMavenCentralRepository to publishAllPublicationsToMavenCentralRepository expands which artifacts are published for the telemetry module. While this may be necessary to address the missing dependency issue with the platform-suffixed artifact, it's important to confirm:

  1. Is this the intended behavior (publishing all telemetry publications to Maven Central)?
  2. What other platform-specific publications exist, and are they all suitable for Maven Central release?
  3. Does this align with how other modules in the workflow are published?

For context, the API and UI modules still use publishMavenPublicationToMavenCentralRepository (singular publication), whereas telemetry now uses publishAllPublications....

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swolfand swolfand merged commit 2eb860e into main Dec 15, 2025
10 checks passed
@swolfand swolfand deleted the cursor/MOBILE-363-clerk-android-missing-dependency-0baf branch December 15, 2025 18:22
swolfand added a commit that referenced this pull request Dec 18, 2025
@swolfand @cursoragent
Clerk android missing dependency (#424)
3ee564e 
* Fix telemetry artifact name in maven publish config

Co-authored-by: sam <[email protected]>

* Refactor: Update telemetry publishing and artifact naming

Co-authored-by: sam <[email protected]>

* remove core

---------

Co-authored-by: Cursor Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolfand @cursoragent